[FEATURE][ML] Allow parsing different types of results from analytics… #38430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/ml-core |
droberts195
approved these changes
Feb 5, 2019
droberts195
left a comment
droberts195
left a comment
There was a problem hiding this comment.
I left one comment about using a deprecated method.
Aside from that I can see there are a few TODOs, but I'm happy to merge to the feature branch.
| SearchHit hit = row.getHit(); | ||
| Map<String, Object> source = new LinkedHashMap(hit.getSourceAsMap()); | ||
| source.putAll(result.getResults()); | ||
| IndexRequest indexRequest = new IndexRequest(hit.getIndex(), hit.getType(), hit.getId()); |
There was a problem hiding this comment.
This method is deprecated, so it would be best not to use it in new code:
@deprecated Types are in the process of being removed. Use {@link #IndexRequest(String)} with {@link #id(String)} instead.
dimitris-athanasiou
deleted the
allow-parsing-different-types-of-results-from-analytics-process
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… process