[BACKPORT] Limit token expiry to 1 hour maximum (#38244) #38392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bizybot
added
:Security/Authentication
Collaborator
|
Pinging @elastic/es-security |
We mention in our documentation for the token expiration configuration maximum value is 1 hour but do not enforce it. This commit adds max limit to the TOKEN_EXPIRATION setting. Note: Since this is a backport and the min max time value support was not there in 6.x, I have selectively picked the change from Setting. The changes were done for zen2.
bizybot
force-pushed
the
backport-token-expiry-limit
branch
from
fc52246 to
e6c9b83
Compare
Contributor
Author
jkakavas
approved these changes
Feb 5, 2019
Contributor
jkakavas
left a comment
jkakavas
left a comment
There was a problem hiding this comment.
LGTM Yogesh, I see no reason for not cherry picking the minMaxTimeValueParser to 6.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We mention in our documentation for the token
expiration configuration maximum value is 1 hour
but do not enforce it. This commit adds max limit
to the TOKEN_EXPIRATION setting.
Note: Since this is a backport and the min max
time value support was not there in 6.x, I have
selectively picked the change from Setting.
The changes were done for zen2.