Contradictory type checks

[krisds]

As requested, I will split #38033 into separate PRs. Here is the second part.

This one resolves:

• Contradictory type checks

[elasticmachine]

Pinging @elastic/es-search

[costin]

Looks like I've commented incorrectly at #38151 (comment)

I'll post it here FTR:

Thanks for raising the PR.
However I don't think the proposed solution is correct; I can see how an analysis tool will pick it up (Literal and NamedExpression used to be different hierarchies which got unified at some point though they might be split again).
As the literal already inherits the NamedExpression behavior , the correct solution would be to remove the literal check all together - let me know if you want to pursue this or not.
Thanks,

[javanna]

hi @krisds have you seen the comment above? Are you for addressing your PR? Thanks!

[krisds]

@javanna Yes, I can fix that. Will do.

[javanna]

@costin can you have a look and merge this when ready please?

[javanna]

test this please

[matriv]

Closing this PR as the code has been changed and the relevant block doesn't exist anymore.