Fix MasterServiceTests.testClusterStateUpdateLogging #38116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the test to not use a `CountDownlatch`, instead adding an assertion for the final logging message and waiting until the `MockAppender` has seen it before proceeding. Related to df2c06f Resolves elastic#23739
dakrone
added
>test
Collaborator
|
Pinging @elastic/es-core-infra |
Member
Author
|
@elasticmachine run elasticsearch-ci/2 |
2 similar comments
Member
Author
|
@elasticmachine run elasticsearch-ci/2 |
Member
Author
|
@elasticmachine run elasticsearch-ci/2 |
…s-testClusterStateUpdateLogging
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Feb 1, 2019
This changes the test to not use a `CountDownlatch`, instead adding an assertion for the final logging message and waiting until the `MockAppender` has seen it before proceeding. Related to df2c06f Resolves elastic#23739
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Feb 1, 2019
This changes the test to not use a `CountDownlatch`, instead adding an assertion for the final logging message and waiting until the `MockAppender` has seen it before proceeding. Related to df2c06f Resolves elastic#23739
This was referenced Feb 1, 2019
dakrone
added a commit
that referenced
this pull request
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the test to not use a
CountDownlatch, instead adding an assertionfor the final logging message and waiting until the
MockAppenderhas seen itbefore proceeding.
Related to df2c06f where it was previously done for a different test.
Resolves #23739