Skip to content

Conversation

@dnhatn
Copy link
Member

@dnhatn dnhatn commented Jan 31, 2019

Since #37992 the retainingSequenceNumber is initialized with 0 while the global checkpoint can be -1.

Relates #37992

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests v7.0.0 :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. v6.7.0 labels Jan 31, 2019
@dnhatn dnhatn requested a review from jasontedor January 31, 2019 18:15
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dnhatn
Copy link
Member Author

dnhatn commented Feb 1, 2019

Thanks @jasontedor.

@dnhatn dnhatn merged commit a8ebe2a into elastic:master Feb 1, 2019
@dnhatn dnhatn deleted the fix-soft-deletes-random branch February 1, 2019 01:50
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Feb 1, 2019
Since elastic#37992 the retainingSequenceNumber is initialized with 0 
while the global checkpoint can be -1.

Relates elastic#37992
dnhatn added a commit that referenced this pull request Feb 1, 2019
Since #37992 the retainingSequenceNumber is initialized with 0 
while the global checkpoint can be -1.

Relates #37992
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >test Issues or PRs that are addressing/adding tests v6.7.0 v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants