Support both typed and typeless 'get mapping' requests in the HLRC (backport to 6.x). #37950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtibshirani
added
:Search Foundations/Mapping
Collaborator
|
Pinging @elastic/es-search |
jtibshirani
force-pushed
the
get-mapping-hlrc
branch
from
a9946d6 to
efaf8c7
Compare
…lastic#37796) From previous PRs, we've already added support for include_type_name to the get mapping API. This PR adds a typeless 'get mappings' method to the Java HLRC, that accepts new client-side request and response objects. This new response only handles typeless mapping definitions. Finally, the PR also performs some small, related clean-up around 'get field mappings'.
jtibshirani
force-pushed
the
get-mapping-hlrc
branch
from
efaf8c7 to
f4f9acc
Compare
Contributor
Author
|
@elasticmachine run elasticsearch-ci/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #37796, opening a PR to get a full build. This PR also makes the relevant
changes to account for the difference in the default for
include_type_name.I also needed to backport parts of #37492 that affected tests and documentation.