SQL: Fix BasicFormatter NPE #37804
Merged
SQL: Fix BasicFormatter NPE #37804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matriv
approved these changes
Jan 24, 2019
Contributor
matriv
left a comment
matriv
left a comment
There was a problem hiding this comment.
LGTM. Left 2 comments about logging in tests.
| + "1953-09-02T00:00:00.000Z", result[2]); | ||
| assertEquals("dog |1.7976931348623157E308|123124.888 |9912 |goat |" | ||
| + "2000-03-15T21:34:37.443Z", result[3]); | ||
| logger.info(result[0]); |
Contributor
Author
There was a problem hiding this comment.
We don't. Not paying attention. Thanks for catching.
x-pack/plugin/sql/src/test/java/org/elasticsearch/xpack/sql/action/BasicFormatterTests.java
Outdated
Show resolved
Hide resolved
costin
approved these changes
Jan 24, 2019
Contributor
Author
|
@elasticmachine run elasticsearch-ci/1 |
astefan
added a commit
that referenced
this pull request
Jan 24, 2019
(cherry picked from commit 163a27b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lacking tests for this made the bug go through and discovered by manual testing. This PR should fix the bug and, also, adds tests. Bug introduced with #37602