-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Implement proof of concept ccr recovery #37790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 80c0efe.
…martijnvg/elasticsearch into martijnvg-ccr_handle_fallen_behind_leader
…martijnvg/elasticsearch into martijnvg-ccr_handle_fallen_behind_leader
Contributor
Author
|
As I mention in the description this is kind of rough. There is no retry or error handling. Additionally, there are shortcomings like (I think) we need to retain the original follower request as its options need to be retained for recovery bootstrapping. |
Collaborator
|
Pinging @elastic/es-distributed |
…xception with a special header instead. MissingHistoryOperationsException couldn't be used because it ended up getting serialized in certain cases and this exception was then not handled correctly.
…otFoundException with" This reverts commit 3025289.
a different place where it never gets serialized and there covert it into the wrapper exception.
…martijnvg/elasticsearch into martijnvg-ccr_handle_fallen_behind_leader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR opens a proof of concept for CCR recovery. It is pretty basic
without much resiliency to failures. It pulls in the work from #35719,
#37733 and #37562 and integrates it. There is a single test added to
ensure that files are being recovered when the follower falls behind.