Add test coverage for Painless general casting of boolean and Boolean #37780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
>test
Collaborator
|
Pinging @elastic/es-core-infra |
Contributor
Author
|
@elasticmachine test this please |
1 similar comment
Contributor
Author
|
@elasticmachine test this please |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/1 |
1 similar comment
Contributor
Author
|
@elasticmachine run elasticsearch-ci/1 |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/1 |
2 similar comments
Contributor
Author
|
@elasticmachine run elasticsearch-ci/1 |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/1 |
jdconrad
added a commit
that referenced
this pull request
Jan 30, 2019
…#37780) This adds test coverage for general casts in Painless between boolean and other types and Boolean and other types.
Contributor
Author
|
@rjernst Thanks for the review! |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jan 30, 2019
* master: Remove types from watcher docs (elastic#38002) Add test coverage for Painless general casting of boolean and Boolean (elastic#37780) Fixed test bug, lastFollowTime is null if there are no follower indices. Add ECS schema for user-agent ingest processor (elastic#37727) (elastic#37984) Extract TransportRequestDeduplication from ShardStateAction (elastic#37870) Expose retention leases in shard stats (elastic#37991)
jasontedor
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jan 31, 2019
* elastic/master: ILM setPriority corrections for a 0 value (elastic#38001) Temporarily disable BWC for retention lease stats (elastic#38049) Skip Shrink when numberOfShards not changed (elastic#37953) Add dispatching to `HandledTransportAction` (elastic#38050) Update httpclient for JDK 11 TLS engine (elastic#37994) Reduce flaxiness of ccr recovery timeouts test (elastic#38035) Fix ILM status to allow unknown fields (elastic#38043) Fix ILM Lifecycle Policy to allow unknown fields (elastic#38041) Update verify repository to allow unknown fields (elastic#37619) [ML] Datafeed deprecation checks (elastic#38026) Deprecate minimum_master_nodes (elastic#37868) Remove types from watcher docs (elastic#38002) Add test coverage for Painless general casting of boolean and Boolean (elastic#37780) Fixed test bug, lastFollowTime is null if there are no follower indices. Add ECS schema for user-agent ingest processor (elastic#37727) (elastic#37984) Extract TransportRequestDeduplication from ShardStateAction (elastic#37870)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds test coverage for general casts in Painless between boolean and other types and Boolean and other types.