Skip to content

Log document id when MapperParsingException occurs #37659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Log document id when MapperParsingException occurs #37659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c18594d
Log document id when MapperParsingException occurs
dr0i Jan 21, 2019
c9af65b
Remove trailing space
dr0i Jan 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/src/main/java/org/elasticsearch/index/mapper/FieldMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,8 @@ public Mapper parse(ParseContext context) throws IOException {
context.doc().add(field);
}
} catch (Exception e) {
throw new MapperParsingException("failed to parse [" + fieldType().name() + "]", e);
throw new MapperParsingException("failed to parse [" + fieldType().name() + "] of document with id '"
+ context.sourceToParse().id() + "'", e);
}
multiFields.parse(this, context);
return null;
Expand Down
6 changes: 3 additions & 3 deletions core/src/test/java/org/elasticsearch/index/mapper/LegacyDateFieldMapperTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ public void testIgnoreMalformedOption() throws Exception {
.bytes());
} catch (MapperParsingException e) {
assertThat(e.getCause(), instanceOf(IllegalArgumentException.class));
assertThat(e.getMessage(), is("failed to parse [field2]"));
assertThat(e.getMessage(), is("failed to parse [field2] of document with id '1'"));
}

// Verify that the default is false
Expand All @@ -328,7 +328,7 @@ public void testIgnoreMalformedOption() throws Exception {
.bytes());
} catch (MapperParsingException e) {
assertThat(e.getCause(), instanceOf(IllegalArgumentException.class));
assertThat(e.getMessage(), is("failed to parse [field3]"));
assertThat(e.getMessage(), is("failed to parse [field3] of document with id '1'"));
}

// Unless the global ignore_malformed option is set to true
Expand All @@ -353,7 +353,7 @@ public void testIgnoreMalformedOption() throws Exception {
.bytes());
} catch (MapperParsingException e) {
assertThat(e.getCause(), instanceOf(IllegalArgumentException.class));
assertThat(e.getMessage(), is("failed to parse [field2]"));
assertThat(e.getMessage(), is("failed to parse [field2] of document with id '1'"));
}
}

Expand Down