[ML] Rename analytics package to dataframe #37583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/ml-core |
hendrikmuhs
reviewed
Jan 18, 2019
| import org.elasticsearch.xpack.ml.analytics.DataFrameFields; | ||
| import org.elasticsearch.xpack.ml.analytics.process.AnalyticsProcessManager; | ||
| import org.elasticsearch.xpack.ml.dataframe.DataFrameDataExtractorFactory; | ||
| import org.elasticsearch.xpack.ml.dataframe.DataFrameFields; |
There was a problem hiding this comment.
the only downside I see: I have a class DataFrameField in the data frame plugin. When working with an IDE it's easy to pick the wrong one. But that's also true for the HLRC, anyway, if you see a chance for a better name, that would be great.
(off-topic comment, the classname hasn't changed in this PR)
benwtrent
approved these changes
Jan 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Isolating renaming for ease of review.