Skip to content

Remove the AbstracLifecycleComponent constructor with Settings #37523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2019
Merged

Remove the AbstracLifecycleComponent constructor with Settings #37523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37de0fe
Remove the AbstracLifecycleComponent constructor with Settings
pgomulka Jan 16, 2019
fc3f846
removing unused import
pgomulka Jan 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion docs/reference/migration/migrate_7_0/java.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,10 @@ because `Settings` is no longer needed.
==== Deprecated method `Client#termVector` removed

The client method `termVector`, deprecated in 2.0, has been removed. The method
`termVectors` (plural) should be used instead.
`termVectors` (plural) should be used instead.

[float]
==== Deprecated constructor `AbstractLifecycleComponent(Settings settings)` removed

The constructor `AbstractLifecycleComponent(Settings settings)`, deprecated in 6.7
has been removed. The parameterless constructor should be used instead.
6 changes: 0 additions & 6 deletions server/src/main/java/org/elasticsearch/common/component/AbstractLifecycleComponent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@

import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.elasticsearch.common.settings.Settings;

import java.io.IOException;
import java.util.List;
Expand All @@ -36,11 +35,6 @@ public abstract class AbstractLifecycleComponent implements LifecycleComponent {

protected AbstractLifecycleComponent() {}

@Deprecated
protected AbstractLifecycleComponent(Settings settings) {
// TODO drop settings from ctor
}

@Override
public Lifecycle.State lifecycleState() {
return this.lifecycle.state();
Expand Down