Migrate Streamable to Writeable for recovery package #37380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liketic
changed the title
Member
|
@liketic Thanks for picking up this :). It would be easier to review if you migrate one class or one package per PR. Would you mind narrowing this PR to the "recovery" package only? |
liketic
force-pushed
the
migrate-Streamble-to-Writeable
branch
from
43c60bb to
2859ee8
Compare
Author
|
Thanks @dnhatn , 👍 I updated this as you requested. Could you please review again? |
liketic
changed the title
dnhatn
added
the
:Distributed Indexing/Recovery
Collaborator
|
Pinging @elastic/es-distributed |
Member
|
@liketic Thank you! I will have a look. |
Member
|
@elasticmachine retest this please. |
Member
|
@elasticmachine retest this please. |
dnhatn
reviewed
Jan 23, 2019
server/src/main/java/org/elasticsearch/action/admin/indices/recovery/RecoveryRequest.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/support/broadcast/BroadcastRequest.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/elasticsearch/action/admin/indices/recovery/TransportRecoveryAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/indices/recovery/RecoveryState.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/indices/recovery/RecoveryState.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/indices/recovery/RecoveryState.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/indices/recovery/RecoveryState.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/indices/recovery/RecoveryState.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/indices/recovery/RecoveryTargetTests.java
Show resolved
Hide resolved
…e-Streamble-to-Writeable
Member
|
Thanks @liketic. This is really good already but one more ask. Could you please move |
Author
|
@dnhatn I updated as you requested. Please review again. |
Member
|
I have merged this and backported to 6.x. Thanks again @liketic. |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jan 25, 2019
* elastic/master: (68 commits) Fix potential IllegalCapacityException in LLRC when selecting nodes (elastic#37821) Mute CcrRepositoryIT#testFollowerMappingIsUpdated Fix S3 Repository ITs When Docker is not Available (elastic#37878) Pass distribution type through to docs tests (elastic#37885) Mute SharedClusterSnapshotRestoreIT#testSnapshotCanceledOnRemovedShard SQL: Fix casting from date to numeric type to use millis (elastic#37869) Migrate o.e.i.r.RecoveryState to Writeable (elastic#37380) ML: removing unnecessary upgrade code (elastic#37879) Relax cluster metadata version check (elastic#37834) Mute TransformIntegrationTests#testSearchTransform Refactored GeoHashGrid unit tests (elastic#37832) Fixes for a few randomized agg tests that fail hasValue() checks Geo: replace intermediate geo objects with libs/geo (elastic#37721) Remove NOREPLACE for /etc/elasticsearch in rpm and deb (elastic#37839) Remove "reinstall" packaging tests (elastic#37851) Add unit tests for ShardStateAction's ShardStartedClusterStateTaskExecutor (elastic#37756) Exit batch files explictly using ERRORLEVEL (elastic#29583) TransportUnfollowAction should increase settings version (elastic#37859) AsyncTwoPhaseIndexerTests race condition fixed (elastic#37830) Do not allow negative variances (elastic#37384) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate more classes to
Writable.Relates to #34389