Skip to content

Testclusters logging improovements #37354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 25, 2019
Merged

Testclusters logging improovements #37354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
02d0a0a
Logging improvements for testclusters
alpar-t Jan 11, 2019
d7999f5
Loggin improvements for test clusters
alpar-t Jan 11, 2019
faefab5
Merge remote-tracking branch 'origin/master' into testclusters-loggin…
alpar-t Jan 22, 2019
6a40f44
Merge remote-tracking branch 'origin/master' into testclusters-loggin…
alpar-t Jan 24, 2019
c7b554c
Merge branch 'master' into testclusters-logging-improovements
alpar-t Jan 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion buildSrc/src/main/java/org/elasticsearch/gradle/testclusters/ElasticsearchNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ private void logFileContents(String description, Path from) {
logger.error("{} `{}`", description, this);
try(Stream<String> lines = Files.lines(from, StandardCharsets.UTF_8)) {
lines
.map(line -> " [" + name + "]" + line)
.map(line -> " " + line)
.forEach(logger::error);
} catch (IOException e) {
throw new UncheckedIOException(e);
Expand Down
4 changes: 3 additions & 1 deletion buildSrc/src/main/java/org/elasticsearch/gradle/testclusters/TestClustersPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,9 @@ private static void shutdownExecutorService() {
}

private static void shutDownAllClusters() {
logger.info("Shutting down all test clusters", new RuntimeException());
if (logger.isDebugEnabled()) {
logger.debug("Shutting down all test clusters", new RuntimeException());
}
synchronized (runningClusters) {
runningClusters.forEach(each -> each.stop(true));
runningClusters.clear();
Expand Down