Skip to content

Conversation

@alpar-t
Copy link
Contributor

@alpar-t alpar-t commented Jan 11, 2019

Use Zen2 by default for test-clusters.
More detailed configuration will be added as needed.

Closes #37218

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@alpar-t alpar-t requested a review from rjernst January 11, 2019 10:36
config.put("cluster.routing.allocation.disk.watermark.flood_stage", "1b");
}
if (Version.fromString(version).onOrAfter(Version.fromString("6.5.0"))) {
config.put("discovery.type", "zen2");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zen2 is the default. Why is this change necessary? These tests are probably already running with Zen2 unless explicitly disabled in some place

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also zen2 is only available in ≥7.0 so onOrAfter(6.5.0) looks wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My goal was to avoid the 3s delay. Will look into it, thanks !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed discovery.type, sorry was looking at an older PR.

}
if (Version.fromString(version).onOrAfter(Version.fromString("6.5.0"))) {
config.put("discovery.type", "zen2");
config.put("cluster.initial_master_nodes", "1");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless your node is named "1", this is not a valid configuration. Please have a look at the docs or reach out to @DaveCTurner or me on how to configure this. Note that if your tests are running a single node in development mode, then no configuration should be necessary.

@alpar-t
Copy link
Contributor Author

alpar-t commented Jan 15, 2019

@ywelsch can you take another look please.

Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this will only make sense as long as your testclusters consist of a single node.

@alpar-t alpar-t merged commit 3a2b616 into elastic:master Jan 21, 2019
@alpar-t alpar-t deleted the testclusters-zen2 branch January 21, 2019 10:52
alpar-t added a commit that referenced this pull request Jan 21, 2019
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v6.7.0 v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test Clusters integration test fails: time out waiting for cluster

6 participants