-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Use zen2 with testclusters #37352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use zen2 with testclusters #37352
Conversation
|
Pinging @elastic/es-core-infra |
| config.put("cluster.routing.allocation.disk.watermark.flood_stage", "1b"); | ||
| } | ||
| if (Version.fromString(version).onOrAfter(Version.fromString("6.5.0"))) { | ||
| config.put("discovery.type", "zen2"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zen2 is the default. Why is this change necessary? These tests are probably already running with Zen2 unless explicitly disabled in some place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also zen2 is only available in ≥7.0 so onOrAfter(6.5.0) looks wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My goal was to avoid the 3s delay. Will look into it, thanks !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed discovery.type, sorry was looking at an older PR.
| } | ||
| if (Version.fromString(version).onOrAfter(Version.fromString("6.5.0"))) { | ||
| config.put("discovery.type", "zen2"); | ||
| config.put("cluster.initial_master_nodes", "1"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless your node is named "1", this is not a valid configuration. Please have a look at the docs or reach out to @DaveCTurner or me on how to configure this. Note that if your tests are running a single node in development mode, then no configuration should be necessary.
|
@ywelsch can you take another look please. |
ywelsch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this will only make sense as long as your testclusters consist of a single node.
Use Zen2 by default for test-clusters.
More detailed configuration will be added as needed.
Closes #37218