Skip to content

SNAPSHOT+TESTS: Stabilize SnapshotDisruptionIT #37289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2019
Merged

SNAPSHOT+TESTS: Stabilize SnapshotDisruptionIT #37289

merged 1 commit into from
Jan 10, 2019

Conversation

@original-brownbear
Copy link
Contributor

@original-brownbear original-brownbear commented Jan 10, 2019 •
edited
Loading

  • Ensure retry by busy assert on SnapshotMissingException
    • This should fix the test since the retry should still happen even when running into the race between retry and deletion as a result of the prior failing snapshot but it could be that the assert is hit right when the delete worked out and the retry hasn't yet happened so we need to make the busy assert retry here
  • Closes [CI] SnapshotDisruptionIT. testDisruptionOnSnapshotInitialization fails unreproducibly #36779

@original-brownbear
SNAPSHOT+TESTS: Stabilize SnapshotDisruptionIT
7990faf 
* Ensure retry by busy assert on SnapshotMissingException
* Closes elastic#36739
@original-brownbear original-brownbear added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v7.0.0 v6.7.0 labels Jan 10, 2019
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 10, 2019

Pinging @elastic/es-distributed

@original-brownbear
Copy link
Contributor Author

original-brownbear commented Jan 10, 2019

Jenkins run Gradle build tests 1

@original-brownbear
Copy link
Contributor Author

original-brownbear commented Jan 10, 2019

Jenkins run Gradle build tests 2

@original-brownbear
Copy link
Contributor Author

original-brownbear commented Jan 10, 2019

Jenkins run Gradle build tests 1

@original-brownbear original-brownbear merged commit 26cb746 into elastic:master Jan 10, 2019
@original-brownbear
Copy link
Contributor Author

original-brownbear commented Jan 10, 2019

Thanks @ywelsch

@original-brownbear original-brownbear deleted the 36779-again branch January 10, 2019 13:13
@original-brownbear original-brownbear mentioned this pull request Jan 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ywelsch ywelsch ywelsch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >test Issues or PRs that are addressing/adding tests v7.0.0-beta1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] SnapshotDisruptionIT. testDisruptionOnSnapshotInitialization fails unreproducibly

4 participants

@original-brownbear @elasticmachine @ywelsch @colings86