Skip to content

Build: Quiet naming convention logging #37244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2019
Merged

Build: Quiet naming convention logging #37244

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6768d0
Build: Quiet naming convention logging
rjernst Jan 8, 2019
1dc0dbb
Merge branch 'master' into naming_logging
rjernst Jan 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions buildSrc/src/main/java/org/elasticsearch/gradle/precommit/TestingConventionsTasks.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,18 +310,18 @@ private boolean seemsLikeATest(Class<?> clazz) {

Class<?> junitTest = loadClassWithoutInitializing("org.junit.Assert", classLoader);
if (junitTest.isAssignableFrom(clazz)) {
getLogger().info("{} is a test because it extends {}", clazz.getName(), junitTest.getName());
getLogger().debug("{} is a test because it extends {}", clazz.getName(), junitTest.getName());
return true;
}

Class<?> junitAnnotation = loadClassWithoutInitializing("org.junit.Test", classLoader);
for (Method method : clazz.getMethods()) {
if (matchesTestMethodNamingConvention(method)) {
getLogger().info("{} is a test because it has method named '{}'", clazz.getName(), method.getName());
getLogger().debug("{} is a test because it has method named '{}'", clazz.getName(), method.getName());
return true;
}
if (isAnnotated(method, junitAnnotation)) {
getLogger().info("{} is a test because it has method '{}' annotated with '{}'",
getLogger().debug("{} is a test because it has method '{}' annotated with '{}'",
clazz.getName(), method.getName(), junitAnnotation.getName());
return true;
}
Expand All @@ -340,7 +340,7 @@ private boolean implementsNamingConvention(Class<?> clazz) {
if (naming.stream()
.map(TestingConventionRule::getSuffix)
.anyMatch(suffix -> clazz.getName().endsWith(suffix))) {
getLogger().info("{} is a test because it matches the naming convention", clazz.getName());
getLogger().debug("{} is a test because it matches the naming convention", clazz.getName());
return true;
}
return false;
Expand Down