-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[DOCS] Rolling upgrade with old internal indices #37184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
albertzaharovits
merged 2 commits into
elastic:master
from
albertzaharovits:rolling_upgrade_with_internal_indices
Jan 9, 2019
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, we're trying to get away from using "X-Pack" terminology. It hasn't been cleaned up everywhere yet, but if we can use something else here, that would be great. Would it be correct to say something like "the Elastic Stack commercial features" instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I am aware that the lingo had changed, but this is a warning message for users of 5.6 when X-Pack is still referred. Moreover, the proper stack upgrade docs in https://www.elastic.co/guide/en/elastic-stack/current/upgrading-elastic-stack.html, where the internal index upgrade step is described, still mention "X-Pack". I think using a different terminology would be confusing in this circumstance.
The decision is yours though, "The format used for the internal indices used by commercial features has changed in 6.x .", sounds equally fine to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, I cleaned up some occurrences of X-Pack in that book yesterday, but there are still lots that seem relevant. This seems like one of those cases.