Move InternalTestClusterTests to zen2 #36977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrershov
added
>test
Collaborator
|
Pinging @elastic/es-distributed |
ywelsch
approved these changes
Dec 24, 2018
| 2 + (masterNodes ? InternalTestCluster.DEFAULT_HIGH_NUM_MASTER_NODES : 0) + maxNumDataNodes + numClientNodes) | ||
| .put(NetworkModule.TRANSPORT_TYPE_KEY, getTestTransportType()) | ||
| .put(USE_ZEN2.getKey(), false) // full cluster restarts not yet supported | ||
| .putList(DISCOVERY_HOSTS_PROVIDER_SETTING.getKey(), "file") |
Contributor
There was a problem hiding this comment.
also set .putList(SettingsBasedHostsProvider.DISCOVERY_ZEN_PING_UNICAST_HOSTS_SETTING.getKey()) // empty list disables a port scan for other nodes?
Contributor
Author
|
run default distro tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today
InternalTestClusterTestsis still using zen1.This commit fixes it.
Two types of changes were required:
ESIntegTestCaseas a part of the Zen2 feature and should be done here as well.autoManageMinMasterNodes = falseperform cluster bootstrap. Currently, I'm usingINITIAL_MASTER_NODE_COUNT_SETTINGsetting that will be replaced withINITIAL_MASTER_NODES_SETTINGonce Replace InMemoryPersistedState with GatewayMetaState in CoordinatorTests #36897 is merged.