Remove bwc logic for token invalidation #36893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes bwc invalidation logic from the TokenService - Removes bwc serialization for InvalidateTokenResponse objects as olf nodes in supported mixed clusters during upgade will be 6.7 and thus will know of the new format - Removes the created field from the InvalidateTokenResponse as it is no longer useful in > 7.0
jkakavas
added
>enhancement
>breaking
>breaking-java
v7.0.0
:Security/Authentication
Collaborator
|
Pinging @elastic/es-security |
Contributor
Author
|
@elasticmachine run the gradle build tests 2 σε παρακαλώ πολύ |
tvernum
approved these changes
Dec 28, 2018
| .should(QueryBuilders.rangeQuery("creation_time").lte(now.minus(24L, ChronoUnit.HOURS).toEpochMilli())))); | ||
| .filter(QueryBuilders.termsQuery("doc_type", "token")) | ||
| .filter(QueryBuilders.boolQuery() | ||
| .must(QueryBuilders.rangeQuery("creation_time").lte(now.minus(24L, ChronoUnit.HOURS).toEpochMilli())))); |
Contributor
There was a problem hiding this comment.
Do we need a bool here? Can't we just add the range directly to the filter?
jkakavas
added a commit
that referenced
this pull request
Jan 9, 2019
This bug was introduced in #36893 and had the effect that execution would continue after calling onFailure on the the listener in checkIfTokenIsValid in the case that the token is expired. In a case of many consecutive requests this could lead to the unwelcome side effect of an expired access token producing a successful authentication response.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes bwc for token invalidation
old nodes in supported mixed clusters during upgrade will be 6.7 and
thus will know of the new format
InvalidateTokenResponse as it is no longer useful in > 7.0
Resolves: #36727