[CCR] Report error if auto follower tries auto follow a leader index with soft deletes disabled #36886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with soft deletes disabled Currently if a leader index with soft deletes disabled is auto followed then this index is silently ignored. This commit changes this behaviour to mark these indices as auto followed and report an error, which is visible in auto follow stats. Marking the index as auto follow is important, because otherwise the auto follower will continuously try to auto follow and fail. Relates to elastic#33007
martijnvg
added
>bug
v7.0.0
:Distributed Indexing/CCR
Collaborator
|
Pinging @elastic/es-distributed |
jasontedor
approved these changes
Dec 20, 2018
Member
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
Thanks for picking this up. Looks good, but I left one comment. Assuming that you address, there is no need for another round.
| if (leaderIndexSettings.getAsBoolean(IndexSettings.INDEX_SOFT_DELETES_SETTING.getKey(), | ||
| IndexMetaData.SETTING_INDEX_VERSION_CREATED.get(leaderIndexSettings).onOrAfter(Version.V_7_0_0)) == false) { | ||
|
|
||
| String message = LoggerMessageFormat.format( |
Member
There was a problem hiding this comment.
I think a plain old String#format can be used here, and then we can avoid adding yet another use of this class (which I ultimately want to remove).
martijnvg
added a commit
that referenced
this pull request
Dec 20, 2018
…with soft deletes disabled (#36886) Currently if a leader index with soft deletes disabled is auto followed then this index is silently ignored. This commit changes this behavior to mark these indices as auto followed and report an error, which is visible in auto follow stats. Marking the index as auto follow is important, because otherwise the auto follower will continuously try to auto follow and fail. Relates to #33007
martijnvg
added a commit
that referenced
this pull request
Dec 20, 2018
…with soft deletes disabled (#36886) Currently if a leader index with soft deletes disabled is auto followed then this index is silently ignored. This commit changes this behavior to mark these indices as auto followed and report an error, which is visible in auto follow stats. Marking the index as auto follow is important, because otherwise the auto follower will continuously try to auto follow and fail. Relates to #33007
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a leader index with soft deletes disabled is auto followed then this index is silently ignored.
This commit changes this behaviour to mark these indices as auto followed and report an error, which is
visible in auto follow stats. Marking the index as auto follow is important, because otherwise the auto follower will continuously try to auto follow and fail.
Relates to #33007