Skip to content

[ML] Followup to annotations index creation #36824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2018
Merged

[ML] Followup to annotations index creation #36824

merged 1 commit into from
Dec 19, 2018

Conversation

@droberts195
Copy link

@droberts195 droberts195 commented Dec 19, 2018

Fixes two minor problems reported after merge of #36731:

  1. Name the creation method to make clear it only creates
    if necessary
  2. Avoid multiple simultaneous in-flight creation requests

[ML] Followup to annotations index creation
6103984 
Fixes two minor problems reported after merge of elastic#36731:

1. Name the creation method to make clear it only creates
   if necessary
2. Avoid multiple simultaneous in-flight creation requests
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 19, 2018

Pinging @elastic/ml-core

@droberts195
Copy link
Author

droberts195 commented Dec 19, 2018

Marked as >non-issue as this doesn't need to be in the release notes separately to #36731.

dimitris-athanasiou
dimitris-athanasiou approved these changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hendrikmuhs
hendrikmuhs approved these changes Dec 19, 2018
View reviewed changes
Copy link

@hendrikmuhs hendrikmuhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@droberts195
Copy link
Author

droberts195 commented Dec 19, 2018

run gradle build tests 1

1 similar comment
@droberts195
Copy link
Author

droberts195 commented Dec 19, 2018

run gradle build tests 1

@droberts195 droberts195 merged commit ad20d6b into elastic:master Dec 19, 2018
@droberts195 droberts195 deleted the improve_annotations_index_creation branch December 19, 2018 13:06
ywelsch pushed a commit that referenced this pull request Dec 19, 2018
@ywelsch
[ML] Followup to annotations index creation (#36824)
d5e6f47 
Fixes two minor problems reported after merge of #36731:

1. Name the creation method to make clear it only creates
   if necessary
2. Avoid multiple simultaneous in-flight creation requests
ywelsch pushed a commit that referenced this pull request Dec 19, 2018
@ywelsch
[ML] Followup to annotations index creation (#36824)
ac6f58d 
Fixes two minor problems reported after merge of #36731:

1. Name the creation method to make clear it only creates
   if necessary
2. Avoid multiple simultaneous in-flight creation requests
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dimitris-athanasiou dimitris-athanasiou dimitris-athanasiou approved these changes

+1 more reviewer

@hendrikmuhs hendrikmuhs hendrikmuhs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:ml Machine learning >non-issue v6.6.0 v6.7.0 v7.0.0-beta1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@droberts195 @elasticmachine @hendrikmuhs @dimitris-athanasiou @jimczi