[Geo] Integrate Lucene's LatLonShape (BKD Backed GeoShapes) as default geo_shape indexing approach
#36743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t `geo_shape` indexing approach (elastic#35320) This commit exposes lucene's LatLonShape field as the default type in GeoShapeFieldMapper. To use the new indexing approach, simply set "type" : "geo_shape" in the mappings without setting any of the strategy, precision, tree_levels, or distance_error_pct parameters. Note the following when using the new indexing approach: * geo_shape query does not support querying by MULTIPOINT. * LINESTRING and MULTILINESTRING queries do not yet support WITHIN relation. * CONTAINS relation is not yet supported. The tree, precision, tree_levels, distance_error_pct, and points_only parameters are deprecated.
nknize
added
>feature
:Analytics/Geo
Collaborator
|
Pinging @elastic/es-analytics-geo |
Collaborator
|
Pinging @elastic/es-search |
Contributor
Author
Contributor
Author
|
Note that this is mostly for CI testing. Not much has changed (w/ the exception of differences in some of the overridden mapping methods) |
…shape field mapper is used
Contributor
Author
|
retest this please |
1 similar comment
Contributor
Author
|
retest this please |
Contributor
Author
|
retest this please |
…tic#36794) Lucene 7.6 uses a smaller encoding for LatLonShape. This commit forks the LatLonShape classes to Elasticsearch's local lucene package. These classes will be removed on the release of Lucene 7.6.
Contributor
|
Note #36834, tags from the forked classes should be removed. |
imotov
reviewed
Dec 19, 2018
Contributor
There was a problem hiding this comment.
Note the following when using the new indexing approach
Sorry, I am a minute too late to submit the review, but I will still ask just for clarification. If a user periodically creates indices using a templates that is using default tree type and any of the functionality that has been changed the first index that they auto create after the upgrade will break their app without a warning?
nknize
added a commit
to nknize/elasticsearch
that referenced
this pull request
Dec 19, 2018
…t `geo_shape` indexing approach (elastic#36743) This commit exposes lucene's LatLonShape field as the default type in GeoShapeFieldMapper. To use the new indexing approach, simply set "type" : "geo_shape" in the mappings without setting any of the strategy, precision, tree_levels, or distance_error_pct parameters. Note the following when using the new indexing approach: * geo_shape query does not support querying by MULTIPOINT. * LINESTRING and MULTILINESTRING queries do not yet support WITHIN relation. * CONTAINS relation is not yet supported. The tree, precision, tree_levels, distance_error_pct, and points_only parameters are deprecated.
danielmitterdorfer
removed
:Analytics/Geo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes lucene's
LatLonShapefield as the default type inGeoShapeFieldMapper. To use the new indexing approach, simply set"type" : "geo_shape"in the mappings without setting any of thestrategy,precision,tree_levels, ordistance_error_pctparameters. Note the following when using the new indexing approach:geo_shapequery does not support querying byMULTIPOINT.LINESTRINGandMULTILINESTRINGqueries do not yet supportWITHINrelation. This will be added in the future as abuffered_query.CONTAINSrelation is not yet supported.tree,precision,tree_levels,distance_error_pct, andpoints_onlyparameters are deprecated.All other
geo_shapefeatures are supported.relates #35320