Deprecation check for classic similarity #36577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a deprecation check for indices which have fields that use the `classic` similarity value.
gwbrown
added
>enhancement
:Search/Search
Collaborator
|
Pinging @elastic/es-core-features |
Collaborator
|
Pinging @elastic/es-search |
26 tasks
jpountz
approved these changes
Dec 14, 2018
Contributor
jpountz
left a comment
jpountz
left a comment
There was a problem hiding this comment.
LGTM. Should we also check for instances of the classic similarity in index settings?
Contributor
Author
|
Yes, we should - I missed that it could be used in settings as well. I've added a check for the settings into this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a deprecation check for indices which have fields that use the
classicsimilarity value.Relates to #36024 and #29187