Add sequence numbers based optimistic concurrency control support to Engine #36467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bleskes
added
>enhancement
v7.0.0
:Distributed Indexing/Engine
Collaborator
|
Pinging @elastic/es-distributed |
s1monw
approved these changes
Dec 11, 2018
Contributor
s1monw
left a comment
s1monw
left a comment
There was a problem hiding this comment.
LGTM - I am not happy with the naming. I think cas should not be in there. Can we just name them expectedSeqId expectedPrimaryTerm for now? That's what for instance Integer.compareAndSet uses as it's parameter names.
| final long seqNo; | ||
| final long term; | ||
| if (loadSeqNo) { | ||
| NumericDocValues seqNos = context.reader().getNumericDocValues(SeqNoFieldMapper.NAME); |
Contributor
There was a problem hiding this comment.
we should clean this up in master once backported. can you put a comment in there?
dnhatn
approved these changes
Dec 11, 2018
server/src/test/java/org/elasticsearch/index/engine/InternalEngineTests.java
Outdated
Show resolved
Hide resolved
Contributor
Author
bleskes
force-pushed
the
cas_seq_no_engine
branch
from
014528f to
594bf52
Compare
Contributor
Author
|
run gradle build tests 1 |
Contributor
Author
|
The build failure was regarding refresh listeners. I don't think it's a related but probably signals a concurrency bug. I tried to reproduce this without success (I run ~300 time). Capturing the info here in case it's needed. |
Contributor
Similar assertion recently failed on master (#24418 (comment)), so looks to be unrelated to your changes here |
Contributor
Author
|
run gradle build tests 1 |
bleskes
added a commit
to bleskes/elasticsearch
that referenced
this pull request
Dec 13, 2018
…Engine (elastic#36467) This commit add support to engine operations for resolving and verifying the sequence number and primary term of the last modification to a document before performing an operation. This is infrastructure to move our (optimistic concurrency control)[http://en.wikipedia.org/wiki/Optimistic_concurrency_control] API to use sequence numbers instead of internal versioning. Relates elastic#36148 Relates elastic#10708
bleskes
added a commit
that referenced
this pull request
Dec 13, 2018
…Engine (#36467) This commit add support to engine operations for resolving and verifying the sequence number and primary term of the last modification to a document before performing an operation. This is infrastructure to move our (optimistic concurrency control)[http://en.wikipedia.org/wiki/Optimistic_concurrency_control] API to use sequence numbers instead of internal versioning. Relates #36148 Relates #10708
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jan 23, 2019
The assertion `assertOpsOnPrimary` does not store seq_no and primary term of successful deletes to the `lastOpSeqNo` and `lastOpTerm`. This leads to failures of the subsequence CAS deletes or indexes with seq_no and term. Moreover, this assertion trips a translog assertion because it bumps the primary term of some operations but not the primary term of the engine. Relates elastic#36467 Closes elastic#37684
dnhatn
added a commit
that referenced
this pull request
Jan 24, 2019
The assertion `assertOpsOnPrimary` does not store seq_no and primary term of successful deletes to the `lastOpSeqNo` and `lastOpTerm`. This leads to failures of the subsequence CAS deletes or indexes with seq_no and term. Moreover, this assertion trips a translog assertion because it bumps the primary term of some operations but not the primary term of the engine. Relates #36467 Closes #37684
dnhatn
added a commit
that referenced
this pull request
Jan 28, 2019
The assertion `assertOpsOnPrimary` does not store seq_no and primary term of successful deletes to the `lastOpSeqNo` and `lastOpTerm`. This leads to failures of the subsequence CAS deletes or indexes with seq_no and term. Moreover, this assertion trips a translog assertion because it bumps the primary term of some operations but not the primary term of the engine. Relates #36467 Closes #37684
talevy
pushed a commit
to talevy/elasticsearch
that referenced
this pull request
Feb 15, 2019
The assertion `assertOpsOnPrimary` does not store seq_no and primary term of successful deletes to the `lastOpSeqNo` and `lastOpTerm`. This leads to failures of the subsequence CAS deletes or indexes with seq_no and term. Moreover, this assertion trips a translog assertion because it bumps the primary term of some operations but not the primary term of the engine. Relates elastic#36467 Closes elastic#37684
talevy
added a commit
that referenced
this pull request
Feb 16, 2019
The assertion `assertOpsOnPrimary` does not store seq_no and primary term of successful deletes to the `lastOpSeqNo` and `lastOpTerm`. This leads to failures of the subsequence CAS deletes or indexes with seq_no and term. Moreover, this assertion trips a translog assertion because it bumps the primary term of some operations but not the primary term of the engine. Relates #36467 Closes #37684
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Mar 1, 2019
Changes were made in elastic#34357 and elastic#36467
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support to engine operations for resolving and verifying the sequence number and primary term of the last modification to a document before performing an operation. This is infrastructure to move our optimistic concurrency control API to use sequence numbers instead of internal versioning.
Relates #36148
Relates #10708
PS there are still discussions about the parameter naming. I'll rename these once we have settled on something.