deprecation info API: 'fix' value for index.shard.check_on_startup #36458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support to check for a value of 'fix' for the index setting `index.shard.check_on_startup` for the deprecation info API. This is no longer a valid value for this setting. relates elastic#36024 relates elastic#33194
Collaborator
|
Pinging @elastic/es-core-features |
26 tasks
Contributor
Author
|
@gwbrown thanks for the review. jenkins test this please |
Contributor
Author
|
@gwbrown - could i get you take one more look ? I updated the details message to be more consistent with #36454 The final output is: "index_settings" : {
"test" : [
{
"level" : "warning",
"message" : "The value [fix] for setting [index.shard.check_on_startup] is no longer valid",
"url" : "https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-7.0.html#_literal_fix_literal_value_for_literal_index_shard_check_on_startup_literal_is_removed",
"details" : "The index [test] has the setting [index.shard.check_on_startup] set to value [fix], but [fix] is no longer a valid value. Valid values are true, false, and checksum"
}
]
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support to check for a value of 'fix' for the index setting
index.shard.check_on_startupfor the deprecation info API. This is no longera valid value for this setting.
relates #36024
relates #33194