Skip to content

[ZEN2] Use Zen2 in REST Tests #36300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Dec 7, 2018
Merged

[ZEN2] Use Zen2 in REST Tests #36300

merged 13 commits into from
Dec 7, 2018

Conversation

@original-brownbear
Copy link
Contributor

@original-brownbear original-brownbear commented Dec 6, 2018

No description provided.

@original-brownbear original-brownbear added >test Issues or PRs that are addressing/adding tests WIP v7.0.0 :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. labels Dec 6, 2018
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 6, 2018

Pinging @elastic/es-distributed

DaveCTurner
DaveCTurner reviewed Dec 6, 2018
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. I left a few questions.

@original-brownbear
Copy link
Contributor Author

original-brownbear commented Dec 6, 2018

@DaveCTurner

I think we should set both properties (for now).

Set to what though? Do you want to set the property in the test settings and revert the code change to prod. code or do you want to actively set a value (1 I guess?) in the prod code when no node count setting but a master list is given?

@original-brownbear
Copy link
Contributor Author

original-brownbear commented Dec 6, 2018

Jenkins test this

@ywelsch
Copy link
Contributor

ywelsch commented Dec 6, 2018

@elasticmachine retest this please

DaveCTurner
DaveCTurner approved these changes Dec 7, 2018
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@original-brownbear original-brownbear merged commit e6d1906 into elastic:master Dec 7, 2018
@original-brownbear original-brownbear deleted the zen2-in-rest-tests branch December 7, 2018 08:15
@alpar-t alpar-t mentioned this pull request Jan 8, 2019
Closed
@colings86 colings86 removed the v7.0.0 label Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaveCTurner DaveCTurner DaveCTurner approved these changes

+1 more reviewer

@ywelsch ywelsch ywelsch left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. >test Issues or PRs that are addressing/adding tests v7.0.0-beta1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@original-brownbear @elasticmachine @ywelsch @DaveCTurner @colings86