SNAPSHOT: Increase Timeout to Stabilize Test #36294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
original-brownbear
commented
Dec 6, 2018
original-brownbear
commented
- 30s is pretty close here, most runs take 25s of the timeout making the test unstable
- closes testDataNodeRestartWithBusyMasterDuringSnapshot fails in CI #36283
* 30s is pretty close here, most runs take 25s of the timeout making the test unstable * closes elastic#36283
original-brownbear
added
>non-issue
>test
Collaborator
|
Pinging @elastic/es-distributed |
ywelsch
approved these changes
Dec 6, 2018
Contributor
ywelsch
left a comment
ywelsch
left a comment
There was a problem hiding this comment.
LGTM. Let's also check as a follow-up if we can speed up the test
Contributor
Author
|
@ywelsch thanks, will look into speeding it up soon then :) |
original-brownbear
added a commit
that referenced
this pull request
Dec 6, 2018
* 30s is pretty close here, most runs take 25s of the timeout making the test unstable * closes #36283
original-brownbear
added a commit
that referenced
this pull request
Dec 6, 2018
* 30s is pretty close here, most runs take 25s of the timeout making the test unstable * closes #36283
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Dec 6, 2018
* master: (133 commits) SNAPSHOT: Increase Timeout to Stabilize Test (elastic#36294) Fix get certificates HLRC API (elastic#36198) Avoid shutting down the only master (elastic#36272) Fix typo in comment Fix total hits serialization of the search response (elastic#36290) Fix FullClusterRestartIT#testRollupIDSchemeAfterRestart Mute FullClusterRestartIT#testRollupIDSchemeAfterRestart as we await a fix. [Docs] Add Profile API limitations (elastic#36252) Make sure test don't use Math.random for reproducability (elastic#36241) Fix compilation ingest: support default pipeline through an alias (elastic#36231) Zen2: Rename tombstones to exclusions (elastic#36226) [Zen2] Hide not recovered state (elastic#36224) Test: mute testDataNodeRestartWithBusyMasterDuringSnapshot Test: mute testSnapshotAndRestoreWithNested Revert "Test: mute failing mtermvector rest test" Test: mute failing mtermvector rest test add version 6.5.3 (elastic#36268) Make hits.total an object in the search response (elastic#35849) [DOCS] Fixes broken link in execute watch ...
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Dec 26, 2018
* This speeds up the test from an average 25s down to 7s runtime * There is no need for artificially slowing down the snapshot to reproduce the issue of an out of sync routing table in practice. Over hundreds of test runs the test's snapshot shard service still runs in the index not found exception every time reproducing this issue. * Relates elastic#36294
Contributor
Author
|
Suggested speedup in #36990 |
original-brownbear
added a commit
that referenced
this pull request
Dec 27, 2018
* This speeds up the test from an average 25s down to 7s runtime * There is no need for artificially slowing down the snapshot to reproduce the issue of an out of sync routing table in practice. Over hundreds of test runs the test's snapshot shard service still runs in the index not found exception every time reproducing this issue. * Relates #36294
original-brownbear
added a commit
that referenced
this pull request
Dec 27, 2018
* This speeds up the test from an average 25s down to 7s runtime * There is no need for artificially slowing down the snapshot to reproduce the issue of an out of sync routing table in practice. Over hundreds of test runs the test's snapshot shard service still runs in the index not found exception every time reproducing this issue. * Relates #36294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.