Skip to content

[Close Index API] Add TransportShardCloseAction for pre-closing verifications #36249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 7, 2018
Merged

[Close Index API] Add TransportShardCloseAction for pre-closing verifications #36249

merged 3 commits into from
Dec 7, 2018

Conversation

@tlrx
Copy link
Member

@tlrx tlrx commented Dec 5, 2018

Note: this pull request will be merged in the close-index-api-refactoring branch

This pull request adds the TransportShardCloseAction which is a transport replication action that acquires all index shard permits for its execution. This action will be used in the future by the MetaDataIndexStateService in a new index closing process, where we need to execute some sanity checks before closing an index.

The action executes the following verifications on the primary and replicas:

  • there is no other on going operation active on the shard
  • the data node holding the shard knows that the index is blocked for writes
  • the shard's max sequence number is equal to the global checkpoint

When the verifications are done and successful, the shard is flushed.

Once this pull request is merged, a follow up pull request will change the MetaDataIndexStateService to make use of this new transport action.

@tlrx tlrx added >enhancement v7.0.0 :Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. labels Dec 5, 2018
@tlrx tlrx requested a review from ywelsch December 5, 2018 11:02
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 5, 2018

Pinging @elastic/es-distributed

tlrx
tlrx commented Dec 5, 2018
View reviewed changes
...er/src/main/java/org/elasticsearch/action/admin/indices/close/TransportShardCloseAction.java Outdated
Copy link
Member Author

@tlrx tlrx Dec 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hesitated on the name of the action and request as it does not really close the shard. Suggestions welcome.

Copy link
Contributor

@bleskes bleskes Dec 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TransportVerifyShardBeforeCloseAction? I know it's long, but it's OK, I think.

Copy link
Member Author

@tlrx tlrx Dec 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion - verbose but better than TransportShardCloseAction

@tlrx tlrx mentioned this pull request Dec 5, 2018
Closed
50 tasks
@tlrx tlrx requested review from bleskes and s1monw December 5, 2018 16:26
bleskes
bleskes approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@bleskes bleskes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left some nits.

...er/src/main/java/org/elasticsearch/action/admin/indices/close/TransportShardCloseAction.java Outdated
Copy link
Contributor

@bleskes bleskes Dec 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TransportVerifyShardBeforeCloseAction? I know it's long, but it's OK, I think.

server/src/main/java/org/elasticsearch/action/admin/indices/close/ShardCloseRequest.java Outdated
Copy link
Contributor

@bleskes bleskes Dec 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just inline this in the transport action file? I don't see the need for another file.

Copy link
Member Author

@tlrx tlrx Dec 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

...er/src/main/java/org/elasticsearch/action/admin/indices/close/TransportShardCloseAction.java Outdated
Copy link
Contributor

@bleskes bleskes Dec 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want a management thread pool here?

Copy link
Member Author

@tlrx tlrx Dec 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

...er/src/main/java/org/elasticsearch/action/admin/indices/close/TransportShardCloseAction.java Outdated
Copy link
Contributor

@bleskes bleskes Dec 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we put the shardId first in the log line so it will look like [index][0] shard is ready for closing ?

Copy link
Member Author

@tlrx tlrx Dec 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@tlrx tlrx force-pushed the add-transport-shard-close-action branch from c5a0dff to d3e786d Compare December 6, 2018 13:49
@tlrx tlrx force-pushed the add-transport-shard-close-action branch from d3e786d to feac528 Compare December 6, 2018 14:31
@tlrx tlrx merged commit 3ca885e into elastic:close-index-api-refactoring Dec 7, 2018
@tlrx tlrx deleted the add-transport-shard-close-action branch December 7, 2018 08:31
@tlrx
Copy link
Member Author

tlrx commented Dec 7, 2018

Thanks @bleskes

@tlrx tlrx mentioned this pull request Dec 7, 2018
Merged
tlrx added a commit that referenced this pull request Dec 13, 2018
@tlrx
[Close Index API] Refactor MetaDataIndexStateService (#36354)
8e5dd20 
The commit changes how indices are closed in the MetaDataIndexStateService. 
It now uses a 3 steps process where writes are blocked on indices to be closed, 
then some verifications are done on shards using the TransportVerifyShardBeforeCloseAction 
added in #36249, and finally indices states are moved to CLOSE and their routing 
tables removed.

The closing process also takes care of using the pre-7.0 way to close indices if the 
cluster contains mixed version of nodes and a node does not support the TransportVerifyShardBeforeCloseAction. It also closes unassigned indices.

Related to #33888
@tlrx tlrx mentioned this pull request Jan 11, 2019
Merged
tlrx added a commit that referenced this pull request Jan 14, 2019
@tlrx
Backport the Close Index API refactoring to 6.x (#37359)
cedf204 
This commit backports to 6.x of the Close Index API refactoring.

It cherry-picks the following commits from master:
3ca885e [Close Index API] Add TransportShardCloseAction for pre-closing verifications (#36249)
8e5dd20 [Close Index API] Refactor MetaDataIndexStateService (#36354)
7372529 [Tests] Reduce randomization in CloseWhileRelocatingShardsIT (#36694)
103c4d4 [Close Index API] Mark unavailable shard copy as stale during verification (#36755)
1959388 [Close Index API] Propagate tasks ids between Freeze, Close and Verify(#36630)
e149b08 [Close Index API] Add unique UUID to ClusterBlock (#36775)
dc371ef [Tests] Fix ReopenWhileClosingIT with correct min num shards

The following two commits were needed to adapt the change to 6.x:
ef6ae69 [Close Index API] Adapt MetaDataIndexStateServiceTests after merge
21b7653 [Tests] Adapt CloseIndexIT tests for 6.x

Related to #33888
@tlrx tlrx mentioned this pull request Feb 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ywelsch ywelsch Awaiting requested review from ywelsch

@s1monw s1monw Awaiting requested review from s1monw

1 more reviewer

@bleskes bleskes bleskes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. >enhancement v7.0.0-beta1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tlrx @elasticmachine @bleskes @colings86