[HLRC] Added support for CCR Stats API #36213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change also adds documentation for the CCR Stats API. Relates to elastic#33824
Collaborator
|
Pinging @elastic/es-core-features |
9 tasks
hub-cap
approved these changes
Dec 4, 2018
Contributor
hub-cap
left a comment
hub-cap
left a comment
There was a problem hiding this comment.
small nits, id like to know the answer to a Q but i wont block.
|
|
||
| static Request getCcrStats(CcrStatsRequest ccrStatsRequest) { | ||
| String endpoint = new RequestConverters.EndpointBuilder() | ||
| .addPathPartAsIs(ccrStatsRequest.getFollowerIndex()) |
Contributor
There was a problem hiding this comment.
.addPathPart() since it has user input
|
|
||
| private static final ConstructingObjectParser<Tuple<String, List<ShardFollowStats>>, Void> ENTRY_PARSER = | ||
| new ConstructingObjectParser<>("entry", args -> { | ||
| String index = (String) args[0]; |
Contributor
There was a problem hiding this comment.
spacing is odd here, maybe tab in the closure a bit more
client/rest-high-level/src/test/java/org/elasticsearch/client/CCRIT.java
Show resolved
Hide resolved
martijnvg
added a commit
that referenced
this pull request
Dec 5, 2018
This change also adds documentation for the CCR Stats API. Relates to #33824
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change also adds documentation for the CCR Stats API.
This is PR is big, but that is mainly because indices follow and auto follow stats response classes and associated tests. These classes just have a lot of fields.
Relates to #33824