[FEATURE][ML] Write control message to signify end of data #36158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/ml-core |
droberts195
approved these changes
Dec 3, 2018
droberts195
left a comment
droberts195
left a comment
There was a problem hiding this comment.
LGTM, although I left one suggestion for a comment
| public class AnalyticsControlMessageWriter extends AbstractControlMsgWriter { | ||
|
|
||
| /** | ||
| * This must match the code defined in the api::CDataFrameAnalyzer C++ class. |
There was a problem hiding this comment.
Since the constant has a different name in the C++ it would be worth stating the C++ name here.
dimitris-athanasiou
deleted the
write-control-message-to-signify-end-of-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.