Upgrade Netty 4.3.32.Final #36102
Merged
Upgrade Netty 4.3.32.Final #36102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit upgrades netty. This will close elastic#35360. Netty started throwing an `IllegalArgumentException` if a `CompositeByteBuf` is created with < 2 components. `Netty4Utils` was updated to reflect this change.
Tim-Brooks
added
blocker
:Distributed Coordination/Network
Collaborator
|
Pinging @elastic/es-distributed |
Contributor
Author
|
This is a blocker for v6.6 and v7.0 as valid SSL failure scenarios can trigger assertions in netty. This was discovered by #35360. It arose from our async connection work that will be introduced in v6.6. The async connection work is fine, it just introduces a code path that accesses the (bug) assertion. |
Tim-Brooks
added a commit
to Tim-Brooks/elasticsearch
that referenced
this pull request
Nov 30, 2018
This commit upgrades netty. This will close elastic#35360. Netty started throwing an IllegalArgumentException if a CompositeByteBuf is created with < 2 components. Netty4Utils was updated to reflect this change.
Tim-Brooks
added a commit
that referenced
this pull request
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit upgrades netty. This will close #35360. Netty started
throwing an
IllegalArgumentExceptionif aCompositeByteBufiscreated with < 2 components.
Netty4Utilswas updated to reflect thischange.