[FEATURE][ML] Only write numeric fields to data frame #35961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/ml-core |
dimitris-athanasiou
force-pushed
the
only-write-numeric-fields-to-data-frame
branch
from
df36f47 to
9b3e32f
Compare
benwtrent
reviewed
Nov 27, 2018
...gin/ml/src/main/java/org/elasticsearch/xpack/ml/analytics/DataFrameDataExtractorFactory.java
Outdated
Show resolved
Hide resolved
Co-Authored-By: dimitris-athanasiou <[email protected]>
droberts195
approved these changes
Nov 28, 2018
droberts195
left a comment
droberts195
left a comment
There was a problem hiding this comment.
Looks good, although I left one suggestion for tightening up immutability of a constant.
| COMPATIBLE_FIELD_TYPES = Stream.of(NumberFieldMapper.NumberType.values()) | ||
| .map(NumberFieldMapper.NumberType::typeName) | ||
| .collect(Collectors.toSet()); | ||
| COMPATIBLE_FIELD_TYPES.add("scaled_float"); // have to add manually since scaled_float is in a module |
There was a problem hiding this comment.
It would be nice if COMPATIBLE_FIELD_TYPES was assigned a Collections.unmodifiableSet. So the static block could build up a temporary set then assign an unmodifiable version to COMPATIBLE_FIELD_TYPES at the end.
dimitris-athanasiou
changed the title
dimitris-athanasiou
deleted the
only-write-numeric-fields-to-data-frame
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.