Fix CompositeBytesReference#slice to not throw AIOOBE with legal offsets. #35955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ets. CompositeBytesReference#slice has two bugs: - One that makes it fail if the reference is empty and an empty slice is created, this is elastic#35950 and is fixed by special-casing empty-slices. - One performance bug that makes it always create a composite slice when creating a slice that ends on a boundary, this is fixed by computing `limit` as the index of the sub reference that holds the last element rather than the next element after the slice. Closes elastic#35950
jpountz
added
>bug
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra |
Tim-Brooks
reviewed
Nov 27, 2018
| FutureObjects.checkFromIndexSize(from, length, this.length); | ||
|
|
||
| if (length == 0) { | ||
| return new BytesArray(BytesRef.EMPTY_BYTES); |
Contributor
There was a problem hiding this comment.
Can you use BytesArray.EMPTY here?
Contributor
Author
There was a problem hiding this comment.
Even better, thanks for the pointer.
jpountz
added a commit
that referenced
this pull request
Nov 30, 2018
…ets. (#35955) CompositeBytesReference#slice has two bugs: - One that makes it fail if the reference is empty and an empty slice is created, this is #35950 and is fixed by special-casing empty-slices. - One performance bug that makes it always create a composite slice when creating a slice that ends on a boundary, this is fixed by computing `limit` as the index of the sub reference that holds the last element rather than the next element after the slice. Closes #35950
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CompositeBytesReference#slice has two bugs:
created, this is [CI] CompositeBytesReferenceTests::testSlice failure #35950 and is fixed by special-casing empty-slices.
creating a slice that ends on a boundary, this is fixed by computing
limitas the index of the sub reference that holds the last element rather than
the next element after the slice.
Closes #35950