Respect indices options on _msearch #35887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we don't repsect the indices options when they are passed as request parameters to the _msearch endpoint. This is unintutive and doesn't cause any errors. This changes uses the top-level indices options as the defaults for each sub-searchrequest.
s1monw
added
>enhancement
:Search/Search
Collaborator
|
Pinging @elastic/es-search |
Contributor
Author
|
closes #35851 |
javanna
approved these changes
Nov 26, 2018
s1monw
added a commit
that referenced
this pull request
Nov 26, 2018
Today we don't respect the indices options when they are passed as request parameters to the `_msearch` endpoint. This is unintuitive and doesn't cause any errors. This changes uses the top-level indices options as the defaults for each sub search-request. Closes #35851
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we don't respect the indices options when they are passed
as request parameters to the _msearch endpoint. This is unintutive
and doesn't cause any errors. This changes uses the top-level indices
options as the defaults for each sub-searchrequest.