SQL: SYS COLUMNS returns ODBC specific schema #35870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-search |
Due to some unresolvable type conflict between the expected definition in JDBC vs ODBC, the driver mode is now passed over so that certain command can change their results accordingly (in this case SYS COLUMNS) Fix elastic#35376
Member
Author
|
run the gradle build tests 1 |
matriv
approved these changes
Nov 23, 2018
Contributor
matriv
left a comment
matriv
left a comment
There was a problem hiding this comment.
LGTM, left cosmetic comment.
| return list.get(10); | ||
| } | ||
|
|
||
| private static Object decimalPrecision(List<?> list) { |
Contributor
There was a problem hiding this comment.
maybe sort them by the list index 8
Contributor
There was a problem hiding this comment.
It's really minor, I mean decimalPrecision could be before radix which is list.get(9).
Contributor
|
The issue you're referring to, is not correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some unresolvable type conflict between the expected definition
in JDBC vs ODBC, the driver mode is now passed over so that certain
command can change their results accordingly (in this case SYS COLUMNS)
Fix #35376