HLRC: Add ability to put user with a password hash #35844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update PutUserRequest to support password_hash (see: elastic#35242) This also updates the documentation to bring it in line with our more recent approach to HLRC docs.
The server has an assert that fails on a PutUser request that doesn't change anything
Contributor
Author
|
CC: @elastic/es-security |
bizybot
approved these changes
Nov 26, 2018
Contributor
bizybot
left a comment
bizybot
left a comment
There was a problem hiding this comment.
LGTM, Thank you. Added a comment if we want to use SecureString but as it was already there for the password I guess it's okay.
|
|
||
| private final User user; | ||
| private final @Nullable char[] password; | ||
| private final @Nullable char[] passwordHash; |
Contributor
There was a problem hiding this comment.
just for my understanding, is there a reason why we do not use SecureString for password/passwordHash in HLRC?
I guess if users use SecureString they will get a warning in IDE if the resource is not closed properly.
Contributor
Author
There was a problem hiding this comment.
We don't use SecureString anywhere in the HLRC.
I think it's conversation worth having (or maybe it already happened, but I can't find it), but I'd prefer it not be buried in this PR.
Contributor
Author
|
@elasticmachine |
tvernum
added a commit
that referenced
this pull request
Nov 29, 2018
Update PutUserRequest to support password_hash (see: #35242) This also updates the documentation to bring it in line with our more recent approach to HLRC docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update PutUserRequest to support password_hash (see: #35242)
This also updates the documentation to bring it in line with our more
recent approach to HLRC docs.