Skip to content

Conversation

@dakrone
Copy link
Member

@dakrone dakrone commented Nov 19, 2018

It's possible that we check the explain status so quickly after the index is
managed that it is still in the "new" phase, having not yet moved to the "hot"
phase.

This commit fixes that by wrapping the checks in assertBusy

Resolves #35690

It's possible that we check the explain status so quickly after the index is
managed that it is still in the "new" phase, having not yet moved to the "hot"
phase.

This commit fixes that by wrapping the checks in `assertBusy`

Resolves elastic#35690
@dakrone dakrone added >non-issue :Data Management/ILM+SLM Index and Snapshot lifecycle management labels Nov 19, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

Copy link
Contributor

@talevy talevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@talevy talevy merged commit cf41df3 into elastic:6.x Dec 7, 2018
jasontedor added a commit to liketic/elasticsearch that referenced this pull request Dec 9, 2018
* elastic/6.x: (37 commits)
  [HLRC] Added support for Follow Stats API (elastic#36253)
  Exposed engine must have all ops below gcp during rollback (elastic#36159)
  TEST: Always enable soft-deletes in ShardChangesTests
  Use delCount of SegmentInfos to calculate numDocs (elastic#36323)
  Add soft-deletes upgrade tests (elastic#36286)
  Remove LocalCheckpointTracker#resetCheckpoint (elastic#34667)
  Option to use endpoints starting with _security (elastic#36379)
  [CCR] Restructured QA modules (elastic#36404)
  RestClient: on retry timeout add root exception (elastic#25576)
  [HLRC] Add support for put privileges API (elastic#35679)
  HLRC: Add rollup search (elastic#36334)
  Explicitly recommend to forceMerge before freezing (elastic#36376)
  Rename internal repository actions to be internal (elastic#36377)
  Core: Remove parseDefaulting from DateFormatter (elastic#36386)
  [ML] Prevent stack overflow while copying ML jobs and datafeeds (elastic#36370)
  Docs: Fix Jackson reference (elastic#36366)
  [ILM] Fix issue where index may not yet be in 'hot' phase (elastic#35716)
  Undeprecate /_watcher endpoints (elastic#36269)
  Docs: Fix typo in bool query (elastic#36350)
  HLRC: Add delete template API (elastic#36320)
  ...
@dakrone dakrone deleted the ilm-fix-lifecycleit-phase branch February 4, 2019 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Data Management/ILM+SLM Index and Snapshot lifecycle management >non-issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants