Forbid negative scores in function_score query #35709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Throw an exception when scores are negative in field_value_factor function - Throw an exception when scores are negative in script_score function Relates to elastic#33309
mayya-sharipova
added
v7.0.0
v6.6.0
>breaking
:Search Relevance/Ranking
Collaborator
|
Pinging @elastic/es-search-aggs |
jimczi
approved these changes
Nov 19, 2018
Contributor
jimczi
left a comment
jimczi
left a comment
There was a problem hiding this comment.
LGTM. I wonder if we also need to check the finalScore
computed by FunctionScoreQuery#FunctionFactorScorer#scorer ? It should not be possible to produce a negative score with the current checks but I could have missed something.
| query: | ||
| term: | ||
| test: value | ||
| "functions": [{ |
jimczi
reviewed
Nov 19, 2018
Contributor
jimczi
left a comment
jimczi
left a comment
There was a problem hiding this comment.
Can you also add a note in the breaking changes ?
Member
|
This this only be made in 7.0, not 6.6? Maybe a deprecation warning in 6.6 instead? |
mayya-sharipova
force-pushed
the
script-score-ensure-nonnegative-scores
branch
from
d55bf1e to
35ebc96
Compare
Contributor
Author
|
@elasticmachine test this please |
original-brownbear
pushed a commit
that referenced
this pull request
Nov 23, 2018
* Forbid negative scores in functon_score query - Throw an exception when scores are negative in field_value_factor function - Throw an exception when scores are negative in script_score function Relates to #33309
mayya-sharipova
added a commit
that referenced
this pull request
Nov 23, 2018
javanna
changed the title
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
function
function
Relates to #33309