SQL: Add Misc Geometry Property functions #35698
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for ST_Dimension, ST_GeometryType, ST_X, ST_Y, ST_XMin, ST_XMax, ST_YMin, ST_YMax functions. Relates to elastic#29872
imotov
added
>enhancement
:Analytics/Geo
Collaborator
|
Pinging @elastic/es-search-aggs |
Contributor
Author
|
retest this please |
13 tasks
Contributor
Author
|
Labeled it as WIP for now since I need to do some conflict resolution here first due to #35521. |
imotov
commented
Nov 21, 2018
| } | ||
|
|
||
| public double minX() { | ||
| return shapeBuilder.buildS4J().getBoundingBox().getMinX(); |
Contributor
Author
There was a problem hiding this comment.
@nknize that's probably not the best way to handle this. Do you have any suggestions on what can be done here?
Contributor
Author
|
Part of this PR is superseded by #41104 and the rest will be implemented on a new basis in a different PR. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for ST_Dimension, ST_GeometryType, ST_X, ST_Y, ST_XMin,
ST_XMax, ST_YMin, ST_YMax functions.
Relates to #29872