HLRC: Add parameters to stopRollupJob API #35545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With elastic#34811 the API for stopping rollup jobs got two new url parameters "wait_for_completion" and "timeout". This change adds these to the HLRC APIs as well. Relates to elastic#34811
cbuescher
added
>enhancement
v7.0.0
:Core/Java High Level REST Client
:StorageEngine/Rollup
Collaborator
|
Pinging @elastic/es-core-infra |
Collaborator
|
Pinging @elastic/es-search-aggs |
cbuescher
changed the title
Member
Author
|
@polyfractal thanks for the review, I just added another commit extending the HL client docs with the two new parameters, in case you want to take another last look at those. Otherwise I'll wait for green and merge after that. |
Contributor
|
Ah good catch, I forgot about the docs for HLRC. ++ :) |
cbuescher
pushed a commit
that referenced
this pull request
Nov 15, 2018
tomcallahan
removed
the
:StorageEngine/Rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #34811 the API for stopping rollup jobs got two new url parameters
"wait_for_completion" and "timeout". This change adds these to the HLRC APIs as
well.
Relates to #34811