Remove Comparable interface from ScoreAccessor #35519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way ScoreAccessor implements `compareTo()` is problematic because it doesn't completely follow the Comparable contract, specificaly symmetry (if x is a ScoreAccessor and y any Number then x.comparTo(y) works, but y.compareTo(x) generally does not even compile). Fortunately we don't seem to use the fact that ScoreAccessor is a Comparable anywhere, so we can simply remove it.
cbuescher
added
>non-issue
:Core/Infra/Scripting
Collaborator
|
Pinging @elastic/es-core-infra |
cbuescher
pushed a commit
that referenced
this pull request
Nov 14, 2018
The way ScoreAccessor implements `compareTo()` is problematic because it doesn't completely follow the Comparable contract, specificaly symmetry (if x is a ScoreAccessor and y any Number then x.comparTo(y) works, but y.compareTo(x) generally does not even compile). Fortunately we don't seem to use the fact that ScoreAccessor is a Comparable anywhere, so we can simply remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way ScoreAccessor implements
compareTo()is problematic because it doesn'tcompletely follow the Comparable contract, specificaly symmetry (if x is a
ScoreAccessor and y any Number then x.comparTo(y) works, but y.compareTo(x)
generally does not even compile). Fortunately we don't seem to use the fact that
ScoreAccessor is a Comparable anywhere, so we can simply remove it.