Skip to content

[Docs] Add missing "?" #35513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2018
Merged

[Docs] Add missing "?" #35513

merged 1 commit into from
Nov 14, 2018

Conversation

@tsouza
Copy link

@tsouza tsouza commented Nov 13, 2018

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS that we support?
  • If you are submitting this code for a class then read our policy for that.

@cbuescher cbuescher added >docs General docs changes :Analytics/SQL SQL querying labels Nov 13, 2018
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 13, 2018

Pinging @elastic/es-search-aggs

cbuescher
cbuescher approved these changes Nov 13, 2018
View reviewed changes
Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but maybe some if the SQL folks would like to double check.

@cbuescher cbuescher changed the title Add missing "?" [Docs] Add missing "?" Nov 13, 2018
@costin
Copy link
Member

costin commented Nov 14, 2018 •
edited
Loading

LGTM.
Thanks!

@cbuescher cbuescher merged commit f415244 into 6.4 Nov 14, 2018
cbuescher pushed a commit that referenced this pull request Nov 14, 2018
[Doc] Correct jdbc url example (#35513)
5c7f25d 
Adds a missing `?` to separate the url parameters.
cbuescher pushed a commit that referenced this pull request Nov 14, 2018
[Doc] Correct jdbc url example (#35513)
afa4138 
Adds a missing `?` to separate the url parameters.
cbuescher pushed a commit that referenced this pull request Nov 14, 2018
[Doc] Correct jdbc url example (#35513)
98e0752 
Adds a missing `?` to separate the url parameters.
@colings86 colings86 deleted the tsouza-patch-missing-question-mark branch May 27, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbuescher cbuescher cbuescher approved these changes

Assignees

No one assigned

Labels

:Analytics/SQL SQL querying >docs General docs changes v6.4.4 v6.5.1 v6.6.0 v7.0.0-beta1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tsouza @elasticmachine @costin @cbuescher @colings86