MINOR: Remove Hack in TestCluster Task #35485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The logic that splits by `","` isn't necessary anymore since elastic#35375 removed the hack that set the comma separated list for the unicast host
original-brownbear
added
>non-issue
v7.0.0
:Distributed Coordination/Cluster Coordination
Collaborator
|
Pinging @elastic/es-distributed |
DaveCTurner
approved these changes
Nov 13, 2018
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
Thanks, this also crossed my mind but I didn't have a chance to check if anything relied on this. LGTM.
Contributor
Author
|
@DaveCTurner thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
","isn't necessary anymore since DISCOVERY: Fix RollingUpgradeTests #35375 removed the hack that set the comma separated list for the unicast host@DaveCTurner just random thing I noticed :)