Prevent non-data nodes to start with dangling indices #35447
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirdolzhenko
added
the
:Distributed Indexing/Distributed
Collaborator
|
Pinging @elastic/es-distributed |
ywelsch
suggested changes
Nov 13, 2018
Contributor
ywelsch
left a comment
ywelsch
left a comment
There was a problem hiding this comment.
I've left a few comments. Note that your check is never called on coordinating-only nodes.
server/src/main/java/org/elasticsearch/env/NodeEnvironment.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/env/NodeEnvironment.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/env/NodeEnvironment.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/env/NodeEnvironment.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/gateway/DanglingIndicesIT.java
Outdated
Show resolved
Hide resolved
added 2 commits
November 13, 2018 10:12
… and error message
…ng unexpected folders
Contributor
Author
|
@ywelsch I addressed your comments, could you pls have another look? |
…t with data shard folders
Contributor
Author
|
@elasticmachine run gradle build tests |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non data node (like pure master or pure coordinator node) could behaves like a data node in terms of picking up dangling indices for other data nodes will automatically import them.
This PR forbids non data nodes to start if any data shard folders in data path are found (presence of
_statemetadata folders are allowed for master node)Closes #27073