Painless Context Doc: Add filter context example #35305
Conversation
mayya-sharipova
added
v7.0.0
v6.6.0
>docs
|
Pinging @elastic/es-core-infra |
|
some vagrant tests failed not related to this PR |
|
|
||
| This script allows to find all documents where the value of `doc['sold']` | ||
| is `false`, and where the cost is less than 18. | ||
|
|
There was a problem hiding this comment.
Instead of "allows to find", I'd just say "finds". Given the straightforwardness of the example, I'd just summarize the intent of the script, instead of repeating what the code says:
This script finds all unsold documents that cost less than $18.
| a script parameter. Submit the following script query request | ||
| to filter all theatre seats for evening performances that are not | ||
| sold yet, and where the cost is less than `params.cost`: | ||
|
|
There was a problem hiding this comment.
I'd tweak this slightly to put the emphasis on parameterizing cost:
Defining cost as a script parameter enables the cost to be configured in the script query request. For example,
the following request finds all available theatre seats for evening performances that are under $18.
jdconrad
left a comment
jdconrad
left a comment
There was a problem hiding this comment.
Tech side of this looks good. Thanks for this example!
|
@debadair Thank you for your feedback. I have modified the doc file according to it. Please let me know if this PR is ready for the approval. |
5 participants
relates to #34829