Zen2: Add diff-based publishing #35290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywelsch
added
>enhancement
v7.0.0
:Distributed Coordination/Cluster Coordination
Collaborator
|
Pinging @elastic/es-distributed |
ywelsch
changed the title
61 tasks
DaveCTurner
reviewed
Nov 8, 2018
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
I left one question. I also think there should perhaps be a few more tests in PublicationTransportHandlerTests showing its behaviour in isolation, although I'm not convinced of this since the coverage through CoordinatorTests is good.
| final DiscoveryNodes nodes = clusterChangedEvent.state().nodes(); | ||
| final ClusterState newState = clusterChangedEvent.state(); | ||
| final ClusterState previousState = clusterChangedEvent.previousState(); | ||
| final boolean sendFullVersion = clusterChangedEvent.previousState().getBlocks().disableStatePersistence(); |
Contributor
There was a problem hiding this comment.
Should we also obey discovery.zen.publish_diff.enable here?
Contributor
Author
There was a problem hiding this comment.
I would like to avoid exposing this as a setting and having this configurable in Zen2, which is why I deliberately opted not to implement this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables diff-based publishing, which is an optimization where only the changing parts of the cluster state are published to the nodes in the cluster, falling back to full cluster state publishing if the receiver does not have the previous cluster state.