Fix UpdateRequest.fromXContent #35257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirdolzhenko
added
:Distributed Indexing/CRUD
Collaborator
|
Pinging @elastic/es-distributed |
nik9000
approved these changes
Nov 5, 2018
Member
nik9000
left a comment
nik9000
left a comment
There was a problem hiding this comment.
LGTM. Crazy that we allow this, but we don't want to break it in a minor. And what you've got makes 6.x better. Crazy. But better.
Do you know if we have a breaking change warning in master for no longer allowing this? I don't think we realized fully what we were fixing when we did this. If we don't have one, could you add one?
Contributor
Author
|
@nik9000 Deprecation message has to be added in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UpdateRequestin6.xcould havedoc,scriptand other valuable commands on any level of depth.All of following requests
{"doc":{"message":"set by update:doc"}}{"whatever":{"doc":{"message":"set by update:doc"}}}{"aaa":{"whatever":{"doc":{"message":"set by update:doc"}}}}are like
{"doc":{"message":"set by update:doc"}}as all unknown fields ignored but parsing continues to look up for commands in depth.Actually parsing of nested object is broken and it leads to issues like #34069.
This PR fixes parsing of nested objects for
UpdateRequestfor6.xbranch.#29293 is a proper fix for
7.0(it forbids such kind of behaviour) but it is breaking change that we could not apply for6.xbranch.Closes #34069