Update snapshots.asciidoc #35251
Merged
Update snapshots.asciidoc #35251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove an extra "a"
cbuescher
previously requested changes
Nov 5, 2018
Member
cbuescher
left a comment
cbuescher
left a comment
There was a problem hiding this comment.
Hi @ZhukovAlexander, thanks for the PR and your first contribution to the repo.
The change looks good to me, however could you change it so we don't end up with that one long line? We try to keep asciidoc line length close to 80 characters (although this is not strictly enforced I think) to make the docs more readable in all kinds of text editors.
cbuescher
added
>docs
Collaborator
|
Pinging @elastic/es-distributed |
Keep line length close to 80 characters
nik9000
pushed a commit
that referenced
this pull request
Nov 5, 2018
nik9000
pushed a commit
that referenced
this pull request
Nov 5, 2018
nik9000
pushed a commit
that referenced
this pull request
Nov 5, 2018
Member
|
Thanks for fixing the line length @ZhukovAlexander! Thanks for the whole fix. I've merged to master and backported to 6.x, 6.5, and 6.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove an extra "a"