Skip to content

Converting DependencyLicensesTask and UpdateShasTask to java #35231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Converting DependencyLicensesTask and UpdateShasTask to java #35231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0a255bc
Converting DependencyLicensesTask and UpdateShasTask to java
Megamiun Nov 4, 2018
90add72
Pushing start of IT
Megamiun Mar 5, 2019
33bb6fb
Correcting tests
Megamiun Mar 5, 2019
ec17b1b
Merge remote-tracking branch 'origin/master' into refactor/updateshas…
alpar-t Mar 6, 2019
3f80c90
Merge remote-tracking branch 'origin/master' into refactor/updateshas…
alpar-t Mar 7, 2019
7d24a86
Fix input annotations
alpar-t Mar 7, 2019
207e096
Trying to correct ITs
Megamiun Mar 8, 2019
a4f4012
Adding plugin classpath
Megamiun Mar 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion buildSrc/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,9 @@ dependencies {
compile localGroovy()
compile "com.carrotsearch.randomizedtesting:junit4-ant:${props.getProperty('randomizedrunner')}"
compile "com.carrotsearch.randomizedtesting:randomizedtesting-runner:${props.getProperty('randomizedrunner')}"


compile "commons-codec:commons-codec:${props.getProperty('commonscodec')}"
Copy link
Contributor

@alpar-t alpar-t Mar 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding this would try to avoid increasing the transitive dependencies if possible

Copy link
Contributor Author

@Megamiun Megamiun Mar 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this to add the possibility of encoding the sha1 byte array to an hex string.

It seems the way to do it is a little more laborious in pure java and the encodeHex method was a Groovy method.

If prefered, I can change the impl to use java directly.

And when making changes, I just need to rebase my branch, correct?

Copy link
Contributor Author

@Megamiun Megamiun Mar 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and the integTest task takes some hours(it didn't complete yet), on my computer, is it normal?

Copy link
Contributor

@alpar-t alpar-t Mar 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Megamiun thanks for the explanation, I think that's good enough reason to add it.
Unfortunately our integ tests do take that long currently, there's many of them and we are working to optimize execution to make them faster.

@elasticmachine test this please


compile 'com.netflix.nebula:gradle-extra-configurations-plugin:3.0.3'
compile 'com.netflix.nebula:nebula-publishing-plugin:4.4.4'
compile 'com.netflix.nebula:gradle-info-plugin:3.0.3'
Expand Down
268 changes: 0 additions & 268 deletions buildSrc/src/main/groovy/org/elasticsearch/gradle/precommit/DependencyLicensesTask.groovy
View file
Open in desktop

This file was deleted.

66 changes: 0 additions & 66 deletions buildSrc/src/main/groovy/org/elasticsearch/gradle/precommit/UpdateShasTask.groovy
View file
Open in desktop

This file was deleted.

Loading